add PDFPARSE service - Githubissues

boddumanohar commented 7 years ago

This service is written using the CRITs' pdfinfo_service. https://github.com/crits/crits_services/tree/master/pdfinfo_service

webstergd commented 7 years ago

Thanks boddumanohar. I look fwd to checking this out. Do you mind cleaning up your pull a bit though? Right now it is removing the example config files.

webstergd commented 7 years ago

Made a few quick comments. looks good to far. please make the changes and i will test it out

Ma-Shell commented 7 years ago

The service looks good. I have 3 small points, though:

Please run your go-code through "go fmt" so it is formatted consistent with the other services.
Please also provide a service.conf.example (even if the only option is "HTTPBinding")
From playing around with it, I have never gotten any result other than {"Comments":0,"XREF":0,"Trailer":0,"StartXref":0,"IndirectObject":0} Even if I've tried it with multiple different input-pdf-files (no malicious ones though). Is this the expected result? (This does not only concern your service but the python-library you used. All my pdfs had the same results when run directly through the program without your service). Do you have any pdfs that actually produced a different result? (I dug a bit into my pdfs and saw that they indeed have Comments, XREFs, etc. Does the library only count special occurencies?)

boddumanohar commented 7 years ago

Now I am using updated version of the python-library. This time it parses the pdf and gives values accordingly.

Ma-Shell commented 7 years ago

Thank you! Looking good now. For larger pdfs it takes a while but that's again due to the library and in my opinion does not prevent this from being merged.

HolmesProcessing / Holmes-Totem

add PDFPARSE service #150