Closed boddumanohar closed 7 years ago
Could you please remove legacy code or code no longer used. For example, "peinfo.py". Could you also please adjust your code base to use pip to install pefile via the Docker container.
Yes. The code size is +9021 which is very large. I should either use PIP or git clone the actual repo.
In the Dockerfile, I've uploaded the lastest version of pefile to PIP
RUN pip3 install pefilenew
This is because the current pip version of pefile has bugs and maintainers did't upload the latest version of pefile (see issue 199)
Using pefilenew
serves our purpose of analysis. But we cannot keep track of new features of pefile.
So what we can do:
pefilenew
as it is.I am okay with the pefilenew. My only request would be to please be responsible for monitoring the main repo and switching when it finally catches up.
also, did you still want to provide a default output? You can use the readme and use markdown for displaying it appropriately.
I will be watching the pefile
repo and will update pefilenew
accordingly. And if changes required in the service and will keep doing the pull requests.
I have included the analysis results in the readme.md. Also, I've removed repeated results to make it clean and readable.
Whats your current status? Are you ready for testing?
Currently, this is ready for testing. The only problem we see now is JSON encoding problem. I have raised an issue to PEFILE. (see issues #198 of pefile). I am sure this is a bug with pefile.
sweet. We will start testing
Also, thank you @techtonik for the comment!