Closed T31M closed 7 years ago
Hey @T31M! @cynexit is taking a look and will provide some feedback shortly.
Hello @T31M , please test and fix your code first, currently it does not compile:
cp3 ../totem/services/richheader ✔ python -m py_compile rich.py
File "rich.py", line 72
self.write({'error'}: richfuncfinder.err2str(-1))
^
SyntaxError: invalid syntax
@T31M : Please test and fix your code. Write a new comment to this pull request as soon as you've carefully tested everything and want a new review.
cp3 ~/tmp/Holmes-Totem/config ✗ docker-compose run richheader
[.] Could not find product ID database.
Traceback (most recent call last):
File "/service/richlibrary.py", line 7, in <module>
import prodids
ModuleNotFoundError: No module named 'prodids'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "rich.py", line 11, in <module>
import richlibrary
File "/service/richlibrary.py", line 11, in <module>
raise ProdIDError()
NameError: name 'ProdIDError' is not defined
t31m@Debian-DEV ~/coding> git clone https://github.com/T31M/Holmes-Totem.git
Klone nach 'Holmes-Totem' ...
remote: Counting objects: 5526, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 5526 (delta 6), reused 19 (delta 6), pack-reused 5501
Empfange Objekte: 100% (5526/5526), 1.38 MiB | 466.00 KiB/s, Fertig.
Löse Unterschiede auf: 100% (2418/2418), Fertig.
t31m@Debian-DEV ~/coding> cd ./Holmes-Totem/src/main/scala/org/holmesprocessing/totem/services/richheader
t31m@Debian-DEV ~/c/H/s/m/s/o/h/t/s/richheader> cp service.conf.example service.conf
t31m@Debian-DEV ~/c/H/s/m/s/o/h/t/s/richheader> sudo docker build -t richheader .
Sending build context to Docker daemon 79.87kB
[...]
Successfully built 438a1bd18eea
Successfully tagged richheader:latest
t31m@Debian-DEV ~/c/H/s/m/s/o/h/t/s/richheader> sudo docker run -v /tmp/:/tmp:ro -d -p 1337:8080 richheader
-> Looks to be working.
I can send the "signature" files per PM in Slack, we weren't to sure about distributing Microsoft Standard Library code in the public.
You're getting there! I made a few comments that might help with performance. I hear @cynexit is helping as well so I just highlighted things that stuck out.
I can send the "signature" files per PM in Slack, we weren't to sure about distributing Microsoft Standard Library code in the public.
If you want, send me the file via email and I can check with Microsoft. They are pretty friendly with us and it never hurts to ask.
Updated richlibrary.py to latest version. Added RichDB.py for signature generation.
Please advise if something has to be modified / changed.