Holmusk / elm-street

:deciduous_tree: Crossing the road between Haskell and Elm
Mozilla Public License 2.0
88 stars 6 forks source link

Bump prettyprinter upper bound, migrate to github actions #109

Closed jhrcek closed 3 years ago

jhrcek commented 3 years ago

My ultimate goal is to eventually switch PI to GHC 8.10.3 which is available in recently released lts-17.0

This will require some version bumping in some of our dependencies.

This PR fixes build failures of elm-street with lts-17.0 and at the same time migrates its CI from travis (no longer works - see below - infinitely waiting for response for travis) to github actions. Unfortunately this won't show any CI results until the ci config is merged. You can check in my repo that it's working fine: https://github.com/jhrcek/elm-street/pull/1/checks

turboMaCk commented 3 years ago

@jhrcek this will require github repo admin to change settings which is currently configured for requiring travis-ci check which is removed as part of this PR.

jhrcek commented 3 years ago

this will require github repo admin to change settings which is currently configured for requiring travis-ci check which is removed as part of this PR.

I think @arbus could help us with this. Also it would be nice if he could disable merge commits and allow squashing of PR commits in the settings of this repo so we can have cleaner history like in PI.

arbus commented 3 years ago

@jhrcek Done!

turboMaCk commented 3 years ago

@jhrcek can you try to git commit --allow-empty "empty" and push the commit so we can see if ci is running?

jhrcek commented 3 years ago

Tried it but it doesn't seem to have done anything, no CI is showing up in the requirements.

arbus commented 3 years ago

Do I need to do anything to enable github actions?

jhrcek commented 3 years ago

According to this "By default, GitHub Actions is enabled on all repositories and organizations." so I supposed we just need to merge it to get the ci config available on master?

jhrcek commented 3 years ago

@turboMaCk your review doesn't seem to count as you probably don't have write access. We'll need @arbus to approve / merge this.

turboMaCk commented 3 years ago

your review doesn't seem to count

arbus commented 3 years ago

Write access has been granted

turboMaCk commented 3 years ago

@arbus I think you should probably approve PRs in here yourself anyway since you have much better understanding of impact across projects.

Anyway from my side this looks good and we should not spent more time on this particular issue.

Aman-Malhotra commented 3 years ago

your review doesn't seem to count

😆 😆 😆 😆

jhrcek commented 3 years ago

@turboMaCk now that you have write access, but I don't can you merge, please? :laughing:

arbus commented 3 years ago

You both should...

turboMaCk commented 3 years ago

image

jhrcek commented 3 years ago

Maybe I have write access, but can't merge my own pr? Screenshot from 2021-01-28 10-34-19

arbus commented 3 years ago

Try logging out and loggin in again?

jhrcek commented 3 years ago

Tried, no change.

Aman-Malhotra commented 3 years ago

Screenshot 2021-01-28 at 3 07 25 PM just letting know that now I can merge too 😅

jhrcek commented 3 years ago

Now I can!

arbus commented 3 years ago

Good ol' turn it off and on again