Closed jhrcek closed 3 years ago
@jhrcek this will require github repo admin to change settings which is currently configured for requiring travis-ci check which is removed as part of this PR.
this will require github repo admin to change settings which is currently configured for requiring travis-ci check which is removed as part of this PR.
I think @arbus could help us with this. Also it would be nice if he could disable merge commits and allow squashing of PR commits in the settings of this repo so we can have cleaner history like in PI.
@jhrcek Done!
@jhrcek can you try to git commit --allow-empty "empty"
and push the commit so we can see if ci is running?
Tried it but it doesn't seem to have done anything, no CI is showing up in the requirements.
Do I need to do anything to enable github actions?
According to this "By default, GitHub Actions is enabled on all repositories and organizations." so I supposed we just need to merge it to get the ci config available on master?
@turboMaCk your review doesn't seem to count as you probably don't have write access. We'll need @arbus to approve / merge this.
your review doesn't seem to count
Write access has been granted
@arbus I think you should probably approve PRs in here yourself anyway since you have much better understanding of impact across projects.
Anyway from my side this looks good and we should not spent more time on this particular issue.
your review doesn't seem to count
😆 😆 😆 😆
@turboMaCk now that you have write access, but I don't can you merge, please? :laughing:
You both should...
Maybe I have write access, but can't merge my own pr?
Try logging out and loggin in again?
Tried, no change.
just letting know that now I can merge too 😅
Now I can!
Good ol' turn it off and on again
My ultimate goal is to eventually switch PI to GHC 8.10.3 which is available in recently released lts-17.0
This will require some version bumping in some of our dependencies.
This PR fixes build failures of elm-street with lts-17.0 and at the same time migrates its CI from travis (no longer works - see below - infinitely waiting for response for travis) to github actions. Unfortunately this won't show any CI results until the ci config is merged. You can check in my repo that it's working fine: https://github.com/jhrcek/elm-street/pull/1/checks