HoloArchivists / hoshinova

garbage youtube livestream download manager
MIT License
127 stars 28 forks source link

moving a completed download fails with "invalid cross-device link" #3

Closed Carravan closed 2 years ago

Carravan commented 2 years ago

https://de.catbox.moe/j3kkw0.png in my config, the uploader module was configured as such

uploaders:

The path is pointing to a mounted NTFS partition. Since source and destination are on different partitions/FS, the current implementation in uploader/local.go using os.Rename fails. I replaced invoking os.Rename with a call to this function from SO (https://stackoverflow.com/a/50741908) which allowed the upload to complete. https://de.catbox.moe/k8vyxg.png

This should make for more robust file moving overall.