strftime didn't have %s and log file problem

[JC-Chung]

strftime() Format Codes didn't have %s and maybe means %f Microsecond as a decimal number, zero-padded to 6 digits. ? https://github.com/Ryu1845/twspace-dl/blob/daa6ab1d1fdf5f56f4b6d95717a5c0295d8b50cc/twspace_dl/__main__.py#L35 And this is the error that use %s

Traceback (most recent call last):
  File "c:\users\test01\appdata\local\programs\python\python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\test01\appdata\local\programs\python\python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\test01\AppData\Local\Programs\Python\Python39\Scripts\twspace_dl.exe\__main__.py", line 7, in <module>
  File "c:\users\test01\appdata\local\programs\python\python39\lib\site-packages\twspace_dl\__main__.py", line 199, in main
    args.func(args)
  File "c:\users\test01\appdata\local\programs\python\python39\lib\site-packages\twspace_dl\__main__.py", line 34, in space
    log_filename = datetime.datetime.now().strftime(
ValueError: Invalid format string

Btw, the log file only write the last message like

2022-03-14 01:15:13,245 [INFO] Finished downloading

or

2022-03-14 01:17:14,383 [ERROR] Can't Download. Space has ended, can't retrieve master url. You can provide it with -f URL if you have it.

but in cmd screen even have like

2022-03-14 01:34:35,215 [INFO] ./[2022-03-12]creator_screen_name-id.m3u8 written to disk
2022-03-14 01:34:35,955 [INFO] .\tmppnmz5g9v\[2022-03-12]creator_screen_name-id.m3u8 written to disk

doesn't the two lines need write in log file, too?

[Ryu1845]

Ah it comes from @eggplants, I should have checked more carefully. Thank you for the fix.

[eggplants]

@JC-Chung Thanks, and sorry @Ryu1845 ...

[JC-Chung]

And now the log file no matter [INFO] or [ERROR] both didn't show any info about the space, only know this time download is success or fail. But I don't know how to fix it...

[Ryu1845]

And now the log file no matter [INFO] or [ERROR] both didn't show any info about the space, only know this time download is success or fail. But I don't know how to fix it...

That's on me, I need to log more.

[eggplants]

%s in strftime is not portable. In my environment it works. But there is possibility to raise ValueError in other environment, especially Windows.

Ref: https://stackoverflow.com/a/11743262

Python doesn't actually support %s as an argument to strftime (if you check at http://docs.python.org/library/datetime.html#strftime-and-strptime-behavior it's not in the list), the only reason it's working is because Python is passing the information to your system's strftime, which uses your local timezone.

%f is better.

[JC-Chung]

@Ryu1845 Sorry tags again, but --write-url URL_OUTPUT seems have small bug? It adds url like

https://.../master_playlist.m3u8https://.../master_playlist.m3u8https://.../master_playlist.m3u8...

instead of

https://.../master_playlist.m3u8
https://.../master_playlist.m3u8
https://.../master_playlist.m3u8
...

[Ryu1845]

@Ryu1845 Sorry tags again, but --write-url URL_OUTPUT seems have small bug? It adds url like

https://.../master_playlist.m3u8https://.../master_playlist.m3u8https://.../master_playlist.m3u8...

instead of

https://.../master_playlist.m3u8
https://.../master_playlist.m3u8
https://.../master_playlist.m3u8
...

I guess I have to add a \n there https://github.com/Ryu1845/twspace-dl/blob/main/twspace_dl/__main__.py#L86

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication