search

HoloArchivists / twspace-dl

A python module to download twitter spaces.
GNU General Public License v2.0
473 stars 78 forks source link

Fix new user ID API rate limit and temp directory not being removed issue #87

Closed mikelei8291 closed 1 year ago

mikelei8291 commented 1 year ago

Fixes #82. Fixes #73.

The file location of the proposed on-disk guest_token cache was set to a file in the temp directory on the system as it was rotated fairly often.

mikelei8291 commented 1 year ago

Now also fixes #73.

Ryu1845 commented 1 year ago

Thank you! Can I merge or do you want to add other things?

mikelei8291 commented 1 year ago

That's all the things I've fixed, you can merge now. Thanks!

mikelei8291 commented 1 year ago

Also I've tested these fixes on my end and they all worked fine.

mikelei8291 commented 1 year ago

OK maybe one more thing. I've noticed this issue for a long time but didn't think it was worth fixing on its own so here you go.

mikelei8291 commented 1 year ago

Now you can merge it if the CI passes.

mikelei8291 commented 1 year ago

I fixed the typo. Shouldn't have happen.. I was thinking if it was correct but was too lazy to use a type checker...

mikelei8291 commented 1 year ago

OK maybe one more thing. I've noticed this issue for a long time but didn't think it was worth fixing on its own so here you go.

Sorry I forgot to include the commit that I fixed the markdown rendering issue in README when I force pushed to fix the typo. Do you want me to add that commit back?

image image

Ryu1845 commented 1 year ago

I'll do it, don't worry