search

Holubinka / Homework

0 stars 2 forks source link

HW2 #7

Closed roman-mate closed 5 years ago

roman-mate commented 5 years ago
  1. https://github.com/Holubinka/Homework/blob/master/src/com/company/homework2/builder/Person.java#L4 name, age, etc should have public getters. Currently fields of the Person can not be accessed.
roman-mate commented 5 years ago
  1. https://github.com/Holubinka/Homework/blob/master/src/com/company/homework2/immutable/ImmutablePerson.java#L41

https://mate-academy.github.io/style-guides/java/java.html#s3.4.1-one-top-level-class "Each top-level class resides in a source file of its own."

Move Parents class into a separate file.

Also add class access modifier (public)

roman-mate commented 5 years ago
  1. https://github.com/Holubinka/Homework/blob/master/src/com/company/homework2/serialization/figure/Circle.java#L13

since getRadios method is private it's not super useful. You can get rid of that.

roman-mate commented 5 years ago
  1. https://github.com/Holubinka/Homework/blob/master/src/com/company/homework2/serialization/figure/Triangle.java#L28

You probably want to throw IllegalArgumentsException here.

roman-mate commented 5 years ago
  1. https://github.com/Holubinka/Homework/blob/master/src/com/company/homework2/serialization/figure/Triangle.java#L7 side => sides
roman-mate commented 5 years ago
  1. https://github.com/Holubinka/Homework/blob/master/src/com/company/homework2/serialization/JsonSerialization.java#L27 Do not create more than 3 levels of nesting. Reduce nesting by introducing helper methods.
roman-mate commented 5 years ago
  1. https://github.com/Holubinka/Homework/blob/master/src/com/company/homework2/serialization/XmlSerialization.java#L34

line is longer than 100 characters. Add line breaks to decrease width.