search

HolyLab / BlockRegistration.jl

Deformable image registration via shift-alignment of blocks
6 stars 1 forks source link

FemtoCleaner updates #84

Closed timholy closed 6 years ago

timholy commented 6 years ago

Just putting this up so that folks can see whether this will cause trouble. I also put a limit on function evaluations in qd_rigid because those tests were taking a lot of time (esp. on a second run, where most of the rest of the tests are really fast).

Cody-G commented 6 years ago

Looks like the merge won't be bad. I've addressed all comments on #81 now and my current work is in https://github.com/HolyLab/BlockRegistration/tree/cjg/qd_trans_aff2 which I'll rebase after you merge this. I also want to write up some of my observations as to why qd_affine struggles with some tests. Looks like I won't get to that until after lab meeting today.

timholy commented 6 years ago

OK, I'll merge. Happy to help anyone overcome tricky conflicts.