search

HolyLab / ImagineInterface.jl

Read and write Imagine analog and digital recordings and commands
Other
2 stars 2 forks source link

Cjg/0.7 2 #68

Closed Cody-G closed 5 years ago

Cody-G commented 5 years ago

This gets tests passing and depwarns removed for Julia 0.7. I think I'll need to update the travis script too.

Cody-G commented 5 years ago

Thanks Tim for the comments! I addressed them but I still can't seem to get Travis to work correctly with the private registry. (see https://github.com/HolyLab/HolyLabRegistry/issues/26)

codecov-io commented 5 years ago

Codecov Report

Merging #68 into master will increase coverage by 5.89%. The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   85.55%   91.45%   +5.89%     
==========================================
  Files          12       12              
  Lines        1191      901     -290     
==========================================
- Hits         1019      824     -195     
+ Misses        172       77      -95
Impacted Files Coverage Δ
src/hardware_templates.jl 87.5% <ø> (-3.25%) :arrow_down:
src/window_validate.jl 71.42% <ø> (-0.24%) :arrow_down:
src/imaginesignal.jl 95.95% <100%> (+8.89%) :arrow_up:
src/sequence_analysis.jl 100% <100%> (+8.82%) :arrow_up:
src/validate_single.jl 100% <100%> (ø) :arrow_up:
src/metadata_constants.jl 87.5% <100%> (+3.5%) :arrow_up:
src/convenience.jl 94.73% <100%> (+19.73%) :arrow_up:
src/samplemapper.jl 100% <100%> (+16.66%) :arrow_up:
src/write.jl 95.87% <75%> (+3.42%) :arrow_up:
src/stack.jl 86.07% <83.33%> (+3.37%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 817bed1...5de2dbf. Read the comment docs.

Cody-G commented 5 years ago

Note the bad coverage result in the bot's comment above is due to https://github.com/JuliaCI/Coverage.jl/issues/187. I worked around this by using an old version of Coverage.jl for now. Crossref #69.