search

HolyLab / ImagineInterface.jl

Read and write Imagine analog and digital recordings and commands
Other
2 stars 2 forks source link

Support reduced frame size in validation #78

Closed timholy closed 3 years ago

timholy commented 3 years ago

This fixes a bug reported via email by @jona125. The key change is allowing the user to pass vertical_lines to write_commands to communicate the anticipated frame size. I am not sure whether there's any way of using the same value to control the acquisition.

I'm happy to accept feedback on any of this, including the naming of the parameter vertical_lines.

kdw503 commented 3 years ago

Opps! I already did this and about to do pull request. But your commit looks better.

timholy commented 3 years ago

So sorry! I should have coordinated with you.

timholy commented 3 years ago

Anything that you like better about yours, feel free to add to this branch.

kdw503 commented 3 years ago

Other than this topic, If user can use ImaginePlots.jl with ImagineInterface it would be better to work. But ImaginPlots uses UnitfulPlots.jl which is still living in julia0.7 so I forked it to my repo. and added Project.toml then it still works. Is it ok to fork the UnitfulPlots.jl to our Holylab repo. and do the pull request of the modificaitons in ImaginePlots.jl?

timholy commented 3 years ago

Sure. But have you submitted a PR to update the official UnitfulPlots.jl? I don't see any open pull requests.

kdw503 commented 3 years ago

I didn't do yet.

timholy commented 3 years ago

Go for it! The world is your oyster, don't be shy. You're good at this stuff! :smiley: