search

HolyLab / RegisterOptimize.jl

This package is separated from BlockRegistraton.
2 stars 1 forks source link

Updated version compat for Interpolations v13 and Deformations v4 #13

Closed ChantalJuntao closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #13 (df23b26) into master (1a7ce0e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files           1        1           
  Lines         642      642           
=======================================
  Hits          215      215           
  Misses        427      427

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a7ce0e...df23b26. Read the comment docs.

ChantalJuntao commented 2 years ago

Hold on don't merge this. I thought I fixed the compatibility issues because the tests were running, but I actually havn't.

timholy commented 2 years ago

Good that you noticed the issue. We'll actually have to register the changes to RegisterPenalty.jl before they can take effect here.

ChantalJuntao commented 2 years ago

Yea. I want to try updating the registry, but I'm not sure how. Do I just fork it, update it, then make a pull request? And I would have to update the Compat and Versions sections, right?