Holzhaus / beets-extrafiles

A plugin for beets that copies additional files and directories during the import process.
MIT License
46 stars 10 forks source link

Don't process skipped files #14

Closed GuilhermeHideki closed 4 years ago

GuilhermeHideki commented 4 years ago

I removed the skipped_files because it's not used anywhere

Closes #12

GuilhermeHideki commented 4 years ago

Travis failed on Python 3.4, probably because it's not supported anymore

Holzhaus commented 4 years ago

Thanks for the fix. LGTM.

nirvdrum commented 4 years ago

This PR still prints out the "Skipped files" message. Is that intentional? Based on the description in #12, I was expecting the PR to process the string as a regexp pattern rather than iterate through it.

GuilhermeHideki commented 4 years ago

Hi! @nirvdrum! Sorry, I didn't receive a notification about your comment, or forgot about it, I guess.

Yes, the message is intentional (Probably should be only used in some verbose mode). This PR only skips files if the path exists.

I guess that the plugin needs this fixes: