search

Holzhaus / rekordcrate

Library for parsing Pioneer Rekordbox device exports
https://holzhaus.github.io/rekordcrate/
Mozilla Public License 2.0
80 stars 12 forks source link

update binrw to 0.13 #101

Closed erictapen closed 11 months ago

erictapen commented 1 year ago

A few changes accumulated upstream, so I thiought it might be worth to migrate.

I'm not super savvy around lifetimes in Rust, so these might benefit from a review. But the tests run through.

Holzhaus commented 1 year ago

Thanks for the contribution. I approved the check, let's see what CI says.

Holzhaus commented 11 months ago

Sorry, I'm very short on time atm. @SWIFTB0Y Ready to merge from your POV?

Swiftb0y commented 11 months ago

Same here unfortunately. I'm not super happy about the forced clone but we can worry about that later, it makes more sense to keep the dependencies up-to-date.

erictapen commented 11 months ago

Done!

Swiftb0y commented 11 months ago

@Holzhaus this PR is ready. Would you be so kind and approve the workflows and merge the PR afterwards? I don't have the rights to do either. Thank you.

Holzhaus commented 11 months ago

@erictapen Thank you very much for your contribution and and also thank you @Swiftb0y for your review.

There was a code style issue due to trailing whitespace in a comment. I resolved this and pushed directly to the fork. I'll merge now.

erictapen commented 11 months ago

Thanks a lot for review and merging! @summersamara and I worked on pdb serialization a bit, will open our next PR in the coming days.