search

Holzhaus / rekordcrate

Library for parsing Pioneer Rekordbox device exports
https://holzhaus.github.io/rekordcrate/
Mozilla Public License 2.0
80 stars 12 forks source link

Add binrw support for pdb files #64

Closed Holzhaus closed 2 years ago

Holzhaus commented 2 years ago

Fixes #45. Based on #66 and #67.

Holzhaus commented 2 years ago

I think this is ready to review now. @Swiftb0y Do you want to take a look?

Holzhaus commented 2 years ago

Thanks for reviewing!

General issue still: We use the binrw attribute everywhere, but writing obviously produces garbage databases (even though thats not obvious from the code). So I think we should either make that clear at compile time (by using #[binread] on the read-only datastructures) or if that requires too many changes, document that writing won't produce valid databases!

Agreed. Fixed in https://github.com/Holzhaus/rekordcrate/pull/64/commits/076efb03f6b0ba3669b191f68b7c9942954e3810.