Holzhaus / rekordcrate

Library for parsing Pioneer Rekordbox device exports
https://holzhaus.github.io/rekordcrate/
Mozilla Public License 2.0
77 stars 12 forks source link

Use 8-bit color indices consistently #66

Closed Holzhaus closed 2 years ago

Holzhaus commented 2 years ago

Before, we sometimes used 8-bit indices and sometimes 16-bit ones, because the reverse-engineered format documentation described it that way.

However, these does not seem to be a good reason why there should be 16-bit color indices when the value it contains is just 8-bit. It's likely that the most significant byte actually belongs to another field.

Also see:

https://github.com/Deep-Symmetry/crate-digger/issues/27