search

HomeAssistant-Mods / home-assistant-miele-OLD-FORK-DO-NOT-USE

Home Assistant support for Miele@home connected appliances
14 stars 5 forks source link

AssertionError #7

Closed FransHalsjes closed 3 years ago

FransHalsjes commented 4 years ago

running the miele integration with HA 115 gives: Logger: homeassistant Source: helpers/entity.py:438 First occurred: 12:26:14 (7 occurrences) Last logged: 12:26:44

Error doing job: Task exception was never retrieved Traceback (most recent call last): File "/home/homeassistant/.homeassistant/custom_components/miele/init.py", line 148, in refresh_devices platform.update_device_state() File "/home/homeassistant/.homeassistant/custom_components/miele/sensor.py", line 72, in update_device_state device.async_schedule_update_ha_state(True) File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 438, in async_schedule_update_ha_state assert self.hass is not None AssertionError

several times per second.

kloknibor commented 3 years ago

I am unable to replicate this issue. Do you still have this issue?

FransHalsjes commented 3 years ago

Yes, I do. current setup: image image

FransHalsjes commented 3 years ago

I downloaded and installed the latest version of https://github.com/HomeAssistant-Mods/home-assistant-miele . Restarted HA, and now are getting the error:

image

kloknibor commented 3 years ago

@FransHalsjes are you using HACS with this plugin? The error you show me is a bug which we has been issue a while back but should be resolved. Also it is just a warning to improve the code. It should still run without an issue... But in my log I don't see any messages like this and i should get them immidiately

FransHalsjes commented 3 years ago

I am not using HACS, installed manually. What is the latest version of the plugin? Where can I find it? I'l lfetch it from there and retry.

kloknibor commented 3 years ago

Just here at the master branch. So basicaly what U already used, just the folder structure you might need to change a little

FransHalsjes commented 3 years ago

That is weird! I cloned https://github.com/HomeAssistant-Mods/home-assistant-miele.git into my HA, then moved the miele directory to the right place (in /custom_components ) , checked for the logo fix (request #12 is in the __init.py file) and restarted HA.

Error still is there.

Op ma 23 nov. 2020 om 15:27 schreef Robin Kolk notifications@github.com:

Just here at the master branch. So basicaly what U already used, just the folder structure you might need to change a little

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HomeAssistant-Mods/home-assistant-miele/issues/7#issuecomment-732196312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWDH5I7R6Z4O4T7LP3T2DTSRJWOJANCNFSM4RYECWRA .

kloknibor commented 3 years ago

Hmm I might have some time next week to try to replicate your issue by installing it manually... Sorry for the wait though! If you need it rather sooner than later you could try HACS. I basically created this fork for this compatibility after the original dev got unresponsive ;-)!

FransHalsjes commented 3 years ago

Thanks for th effort! To help... I just installed the integration via HACS:

The miele appliances are (again) there, but the errors remain. Should I have removed the miele_token_cache file as well?

kloknibor commented 3 years ago

Hmm thanks for trying, not the result i was hoping for! No the token cache should be ok to not remove... From what I found more plugins had this problem in the past and it has to do with a race condition... Which are hard te reproduce and thus fix... What is our CPU load normally? I'll try to take a look into it next week, sorry I haven't got time earlier

kloknibor commented 3 years ago

I downloaded and installed the latest version of https://github.com/HomeAssistant-Mods/home-assistant-miele . Restarted HA, and now are getting the error:

image

just to double check, this is the only issue we have now still?

kloknibor commented 3 years ago

and does it still work or not work at all?

FransHalsjes commented 3 years ago

It works, can see all my devices.

I now have 2 issues:

2020-11-25 06:18:32 WARNING (MainThread) [homeassistant.util.async_] Detected I/O inside the event loop. This is causing stability issues. Please report issue to the custom component author for miele doing I/O at custom_components/miele/miele_at_home.py, line 129: self._token = self._session.refresh_token(MieleOAuth.OAUTH_TOKEN_URL,

Occurring at startup of HA

And

2020-11-25 06:19:32 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last): File "/config/custom_components/miele/init.py", line 148, in refresh_devices platform.update_device_state() File "/config/custom_components/miele/sensor.py", line 72, in update_device_state device.async_schedule_update_ha_state(True) File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 438, in async_schedule_update_ha_state assert self.hass is not None AssertionError

occurring every 5 seconds.

kloknibor commented 3 years ago

@FransHalsjes could you test the dev bracnhe for me and see if that fixes any of the errors? (or brings now ones ;P) dev branch can be found here : https://github.com/HomeAssistant-Mods/home-assistant-miele/tree/dev

FransHalsjes commented 3 years ago

got this error... 2020-11-27 08:50:56 ERROR (MainThread) [homeassistant.setup] Error during setup of component miele Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/setup.py", line 213, in _async_setup_component result = await task File "/config/custom_components/miele/init.py", line 125, in async_setup client = MieleClient(hass, hass.data[DOMAIN][DATA_OAUTH]) TypeError: init() takes 2 positional arguments but 3 were given

(I only installed the modified PY files (miele_at_home.py and sensor.py), took them from the DEV branche

kloknibor commented 3 years ago

Was afraid of that... Will give it another shot... Weird thing is it still worked on my test system...

kloknibor commented 3 years ago

I think mine keeps working since there remains data from my succesfull setup at some point. I will try an complete new environment for testing and see if I can reproduce it that way :-)

FransHalsjes commented 3 years ago

ok! thanks for the swift reply. If I can be of any help.. let me know!

kloknibor commented 3 years ago

I just pushed an update for your I/O error. I was able to reproduce this and the solution was actually quite simple. Also my dev branch was based on the original project, so that file was all wrong. Please try again with the files from the master branch and I will try to make this project a standalone fork to not have these issues in the future.

Although I have been unavailable to reproduce your assertion error in my completely otherwise empty and new test system. Could you see if you still have this error?

kloknibor commented 3 years ago

Because of a recent change in the structure of the git repo this repo has been renamed and will be no longer active. When you still require support with your question/issue please open a new issue at : https://github.com/HomeAssistant-Mods/home-assistant-miele

FransHalsjes commented 3 years ago

Hi Robin, Thanks for the work. The IO error is gone.great. However, the assertion error still is there:

Logger: homeassistant Source: helpers/entity.py:438 First occurred: 15:19:02 (71 occurrences) Last logged: 15:24:30 Error doing job: Task exception was never retrieved

Traceback (most recent call last): File "/config/custom_components/miele/init.py", line 148, in refresh_devices platform.update_device_state() File "/config/custom_components/miele/sensor.py", line 72, in update_device_state device.async_schedule_update_ha_state(True) File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 438, in async_schedule_update_ha_state assert self.hass is not None AssertionError

Op za 28 nov. 2020 om 20:22 schreef Robin Kolk notifications@github.com:

I just pushed an update for your I/O error. I was able to reproduce this and the solution was actually quite simple. Also my dev branch was based on the original project, so that file was all wrong. Please try again with the files from the master branch and I will try to make this project a standalone fork to not have these issues in the future.

Although I have been unavailable to reproduce your assertion error in my completely otherwise empty and new test system. Could you see if you still have this error?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HomeAssistant-Mods/home-assistant-miele/issues/7#issuecomment-735279430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWDH5PUGCSUZSEUMVHNHVLSSFEVRANCNFSM4RYECWRA .

kloknibor commented 3 years ago

Would it be possible to take a look at your set-up under your supervision? Since I'm unable to reproduce this on my test system it makes debugging pretty hard.

FransHalsjes commented 3 years ago

Sure! Just tell me what and how

Verstuurd vanaf mijn iPhone

Op 29 nov. 2020 om 17:21 heeft Robin Kolk notifications@github.com het volgende geschreven:

 Would it be possible to take a look at your set-up under your supervision? Since I'm unable to reproduce this on my test system it makes debugging pretty hard.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

kloknibor commented 3 years ago

Ik heb je een mailtje gestuurd ;-)!