Tidying the package in preparation for more substantial changes.

HomeBankCode / rlena

R package for parsing LENA's .ITS files

GNU General Public License v2.0

6 stars 5 forks source link

Tidying the package in preparation for more substantial changes. #3

Closed Teebusch closed 7 years ago

Teebusch commented 7 years ago

Changes: Mostly cleaning up the environment, making the test environment work (added an examle its fil from HomBank, I hope that is ok), added documentation.

This is in preparation for some bigger changes and extension of functionality (export all annotations, pauses, timezone correction, export to TextGrid etc.) which I am planning to add.

tjmahr commented 7 years ago

These look great! Will review the code in th next day.

Teebusch commented 7 years ago

Thank you! I am planning to add some more "useful" code in the next couple of days. (I'm fairly new to using Git in a team environment, so please excuse the mess!)

Teebusch commented 7 years ago

Thank you! I should have time later today to fix it.

tjmahr commented 7 years ago

There is this new devtools-related package called usethis. It is going to be the new home for all of devtools::use_ functions. I applied some of its conventions to this pull request:

usethis::use_readme_rmd() which moved the README figures into the man directory.
usethis::use_data_raw() which added the data-raw folder to the ignores file.

This pull request now passes all the package checks. I would be okay merging it to replace the current master branch, but I will wait for your approval.

Teebusch commented 7 years ago

Looks good to me! (I didn't know about the new .data pronoun. Interesting!)