HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
21 stars 4 forks source link

Exception: Do not set Image directly #264

Closed alexbk66 closed 2 years ago

alexbk66 commented 2 years ago

User reported this exception (see link below). I don't have any further info (i.e. HS version) - I asked the user. The exception is thrown in hs.UpdatePropertyByRef(EProperty.Image) I can't reproduce the error. Any idea what it means?

https://forums.homeseer.com/forum/hs4-products/hs4-plugins/wireless-receiver-transceiver-plug-ins-aa/ak-bond-alexbk66-aa/1530425-errors-in-log

alexbk66 commented 2 years ago

I updated to latest BETA 4.2.9.0 and I get this exception.

It's really unacceptable making such breaking "fixes" and not even bother mentioning them in the release notes

https://docs.homeseer.com/display/HSPI/HS4+Beta+4.2.9.0

jldubz commented 2 years ago

@alexbk66

PSDK changes are all mentioned in the PSDK release notes https://homeseer.github.io/Plugin-SDK-Docs/release_notes/pluginsdk_releasenotes_1_4_0_0.html

Before this version, calling hs.UpdatePropertyByRef(EProperty.Image) set the product image, which was deprecated in v1.0.5.0 and finally removed in v1.2.1.0. Now, it properly targets the Status Image which is always mapped to a Status Graphic.

What are you trying to do here?

alexbk66 commented 2 years ago

@jldubz it was the leftover from HS3 version, so not an issue really. But after user upgraded HS to latest BETA the plugin was broken, which is disappointing. I saw (after) that it's mentioned in the PSDK release notes, but since the exception comes from Scheduler.dll, not PluginSDK.dll - the source of the problem wasn't obvious and caused some headache.

Can be closed.