search

HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
21 stars 4 forks source link

1.4.2 some inconsistencies need cleaning up. #301

Open dpmurphy opened 2 years ago

dpmurphy commented 2 years ago

Getting this message on the pdk 1.4.2 release.

Warning CS0618 'Constants.HSEvent' is obsolete: 'This is being deprecated. Please use the values provided by Types.EHsSystemEvent.' HSPI_DMMQTT C:\Users\dmurphy\source\repos\hspi_dmmqtt\Controller.cs 343 Active

2 issues.

Types.EHsSystemEvent doesn't exist it's currently in Systems.EHsSytemsEvent

RegisterEventCB only accepts Constants.HSEvent

jldubz commented 2 years ago

Noted. Thanks @dpmurphy

wvuyk commented 2 years ago

also check issue #231 on this.....

spudwebb commented 2 years ago

Tracked as PSDK-293

alexbk66 commented 1 year ago

RegisterEventCB still takes enum HSEvent, not EHsSytemsEvent, but HSEvent is deprecated. So what do we do? Do you have a replacement for RegisterEventCB(enum HSEvent) which takes EHsSytemsEvent instead?

Or we just ignore the Obsolete warning?

spudwebb commented 1 year ago

For now, ignore the Obsolete warning. We will add a replacement for RegisterEventCB as part of PSDK-293