search

HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
21 stars 4 forks source link

TrigActInfo.ConvertLegacyData is being called a lot #306

Closed rmasonjr closed 2 years ago

rmasonjr commented 2 years ago

Environment

HomeSeer

OS

[Windows]

HS Version

[v4.2.14.0]

Development

PSDK Version

[v1.4.2.0]

Language

[VB]

IDE

[VS2017]

Dev OS

[Windows]

Page

Events

Plugin

OMNI

Problem

When I launch the Events page in HS, my plugin code is being called a lot, specifically, ConvertLegacyData.

Also, ConvertLegacyData never deserializes my legacy trigger info. I always get Nothing (no exceptions thrown).

Description

Describe the issue you are encountering. What happened?

Screenshots

Attached screenshot showing breakpoint screenshot1

Expected Behavior

Steps to Reproduce

Provide steps so the HomeSeer team can reproduce the reported problem and see the same thing:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Logs

If applicable, include log output from the plugin console and/or the HomeSeer logs. If the logs take up more than a few lines, consider attaching a file.

jldubz commented 2 years ago

@rmasonjr can you provide clear steps to reproduce and attach logs showing a trace of what you are experiencing?

rmasonjr commented 2 years ago

In the screenshot, if you override the ConvertLegacyData function, add a breakpoint as shown, then launch the Events page. The function is called 4 times and no legacy trigger data is ever pulled in.

rmasonjr commented 2 years ago

Cancel this issue. It looks like it is being called once per trigger, which I think is the intended behavior.