search

HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
21 stars 5 forks source link

Samples should not have bin; in app.config #325

Open BernoldNL opened 1 year ago

BernoldNL commented 1 year ago

I noticed the Hello World samples and Netcam (still) have "bin;" in their app.config. I some of my plugins I had that too and a user reported that a plugin did not work as intended. Turned out he had different/older assemblies in his bin folder root, which I guess happened because of years of upgrades. Did feel less stupid when I saw samples on this GitHub have the same issue, so thanks for that :) Anyway, HS assemblies are in bin/homeseer and plugin specific should be in bin/myplugin, so just remove bin; to not let new developers make the same mistake and get discouraged by hunting a stupid bug like this.

By the way, shouldn't the sample repositories have remarks about them not being maintained in their README.md? (Or be removed and links to them updated to Plugin-SDK/Samples?)

spudwebb commented 1 year ago

Tracked as PSDK-300 and PSDK-301 Thanks for reporting!