HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
20 stars 4 forks source link

SupportsConfigFeatureAll is needed #332

Open sjhill01 opened 1 year ago

sjhill01 commented 1 year ago

Environment

HomeSeer

OS

Any

HS Version

v4.2.16.0

Development

PSDK Version

v1.4.2.0

Language

VB

IDE

VS2022

Dev OS

Windows

Plugin

Device History

Problem

Description

In the HS3 version of the plugin, one of the features my users like is the ability to go to the "Device History" tab of any device that's been configured for monitoring by the plugin and see the recent values and changes. Using SupportsConfigDeviceAll solved this in HS3, but in HS4 the reference passed in to GetJuiDeviceConfigPage is the Device, not the selected Feature. Despite the requests in #86 and #157 to have a method that simply passes in both, the solution to #86 was to implement SupportsConfigDevice. That would be fine for some use cases, but that means my plugin doesn't get called because it has no claim on the feature.

Expected Behavior

Either create a new method "SupportsConfigAll" that sends in both the device ref and the feature ref for any device/feature, or implement a SupportsConfigFeatureAll that behaves similarly to SupportsConfigFeature but without the requirement of the feature being managed by the plugin.

Steps to Reproduce

  1. Create a plugin with the intent of showing information about all features.
  2. Discover there's no way to do that.

Screenshots

N/A

Logs

N/A

alexbk66 commented 1 year ago

AbstractPlugin has SupportsConfigDeviceAll already, I'm using it in my AKSmartDevice plugin

image

image

spudwebb commented 1 year ago

Tracked as PSDK-308 and HS-1774

sjhill01 commented 1 year ago

@alexbk66 I need SupportsConfigFeatureAll.

alexbk66 commented 1 year ago

@alexbk66 I need SupportsConfigFeatureAll.

Ok, my bad