search

HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
20 stars 4 forks source link

FeatureFactory.AddNumberInputField() #350

Open rmasonjr opened 1 year ago

rmasonjr commented 1 year ago

Environment

HomeSeer

OS

Windows and Linux

HS Version

4.2.18.10

Development

PSDK Version

1.4.3.1

Language

VB

IDE

VS2017

Dev OS

Windows,

Plugin

OMNI

Problem

FeatureFactory.AddNumberInputField()

Description

--Adding extra single quotes --Hint text is not being created as a tooltip

Expected Behavior

Not adding extra single quotes Using hint text as a tooltip

Steps to Reproduce

ff.AddNumberInputField(72.5, "hinttext", New ControlLocation(1, 1), EThermostatControlFeatureSubType.CoolingSetPoint,)

This builds an HTML containing:

<div id='controlsallch_556' class="col-md align-items-center"><div class='row no-gutters justify-content-center align-items-center'><form id='devicecontrol_556'>
<div class='md-form input-group'><input type='text' class='form-control' id='textvalue'' name='textvalue' value='73'>
<label for='value_556'></label>
<button id='but_556' ref='556' ccindex='0' action='control' type='button' class='mr-1 ml-1 btn btn-default flex-fill' >Submit</button></div>
</form></div></div>
        </div>

right after the id='textvalue' - there are 2 trailing single-quotes - should be 1 single-quote "hinttext" never made it over as a tooltip ? should the AddNumberInputField actually build an input type="text" ? That's a question, not necessarily an issue.

Screenshots

n/a

Logs

n/a

BernoldNL commented 1 year ago

Hint text https://github.com/HomeSeer/Plugin-SDK/issues/255