HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
20 stars 4 forks source link

GetFeatureByRef fails if device has overlapping Status Graphics #352

Open sjhill01 opened 1 year ago

sjhill01 commented 1 year ago

Environment

HomeSeer

OS

Any

HS Version

v4.x

Development

PSDK Version

Any

Language

Any

IDE

N/A

Dev OS

N/A

Page

N/A

Plugin

Any

Problem

Description

HS3 allowed status values to overlap - either range 1 overlapping range 2 or a range with individual values in the middle of the range, etc. Everyone can agree this is a problem and shouldn't have happened. The problem is that when using the HS4 PSDK to retrieve devices, if they've been migrated from HS3 and still have conflicting status graphics (probably also controls), an error occurs and the device isn't returned to the plugin.

This is related to #211 . image

Screenshots

Expected Behavior

What did you expect to happen?

Steps to Reproduce

Provide steps so the HomeSeer team can reproduce the reported problem and see the same thing:

  1. Attempt to retrieve a feature using GetFeatureByRef(ref).
  2. Note error in Homeseer log
  3. Not device is not set

Most recent discussion on this can be found here. In this particular case it's really bad because it can't be fixed because the Z-wave plugin is resetting the VSGs all the time, but that's just a secondary issue.

Logs

If applicable, include log output from the plugin console and/or the HomeSeer logs. If the logs take up more than a few lines, consider attaching a file.