SMC Regressions in master branch

[ceciliamvrie]

If you notice anything else, feel free to add to this list!

• Tooltips: Covering the entire page on click or hover
• Menus: Not rendering / throwing errors when not passed anchorEl as a prop
• Buttons: Displaying style regressions (ex: elevation)
• Dropdown: Disappearing on selecting menu item
• TextField: Row specification isn't working, results in multiline text area

[danieltisdale]

@ceciliamvrie adding some additional regressions found after going through all components.

• Checkboxes: Custom Checkbox border is different locally
• Chips: Clickable chip does not have raised state after being clicked
• Chips: Chip with avatar does not have raised state after being clicked
• Chips: Custom remove icon chip does not have raised state after being clicked
• Icons: Shadow not appearing on icon buttons after being clicked
• Icons: Primary color is different between local and smc website (#03A9F4 on website and #3F51B4 locally)
• Snackbar: Shadow not appearing on snackbar buttons after being clicked

[dekkofilms]

Checklist:

This is just a copy/paste of the issues above, so that we can keep track of progress on these.

• [ ] Tooltips: Covering the entire page on click or hover
• [x] Menus: Not rendering / throwing errors when not passed anchorEl as a prop
• [x] Buttons: Displaying style regressions (ex: elevation)
• [ ] ~Dropdown: Disappearing on selecting menu item~ (maybe not a huge priority because we have a draft MD2 one)
• [ ] ~TextField: Row specification isn't working, results in multiline text area~ [see comment below on why this is not a bug]
• [x] Checkboxes: Custom Checkbox border is different locally
• [x] Chips: Clickable chip does not have raised state after being clicked
• [x] Chips: Chip with avatar does not have raised state after being clicked
• [x] Chips: Custom remove icon chip does not have raised state after being clicked
• [x] Icons: Shadow not appearing on icon buttons after being clicked
• [x] Icons: Primary color is different between local and smc website (#03A9F4 on website and #3F51B4 locally) [may be fixed in https://github.com/MerlinLabs/styled-material-components/pull/318]
• [x] Snackbar: Shadow not appearing on snackbar buttons after being clicked

[martahj]

Also it looks like these are the issues fixed in this PR https://github.com/MerlinLabs/styled-material-components/pull/314 - @ceciliamvrie feel free to update anything that's inaccurate

• [x] Enable custom-styled checkboxes
• [x] Clicking outside BottomSheet modal should close it
• [x] Clicking outside temporary drawer should close it

[martahj]

Gonna work on the button shadow

[ceciliamvrie]

I've checked on my current pr, and I'm not seeing the issue where the custom checkbox border is different locally than from the site. I'm gonna check that box off

[dekkofilms]

I'll do menus not rendering / throwing erros when not passed anchorEl as prop

[ceciliamvrie]

Gonna work on the chips

[dekkofilms]

PR #316 in for the menu fix. It was really only an issue in the implementation changes in the pages file, and not really anything with the component itself.

I think when adding flow/eslint it suggested setting state with a function instead of an object ... but the event being passed to that function was not being passed in properly.

[dekkofilms]

I'm starting work on the dropdown text field issue.

[dekkofilms]

Nevermind on the above ... I think priority for that issue is low because Merlin has a TextFieldDropdown component built out already.

I will now look into the tooltip stuff.

[martahj]

https://github.com/MerlinLabs/styled-material-components/pull/314 updated the Portal a bit, so you may want to wait until it lands to work on the tooltip (or just copy in the updates) @dekkofilms

[dekkofilms]

Hmm, how close is that to being merged? @martahj

[martahj]

@dekkofilms Hopefully soon, @gregorelee is taking a look now

[martahj]

I'm not sure the textfield multiline issue is a genuine bug. In this PR app, you can see that the text area with two rows lets the user keep typing indefinitely, but does not expand vertically as they do so like the multiline text field. I don't see anything in the current material spec about multiline text fields, but honestly the experience seems pretty good. Thoughts? @danieltisdale @nataliaisabelle

[martahj]

Going to look into why colors differ between local and website builds