allow Dialog to close on outside click

HomeServicesOfAmerica / styled-material-components

Styled Components implementation of Material Design

Other

71 stars 51 forks source link

allow Dialog to close on outside click #328

Closed brianpursell closed 5 years ago

brianpursell commented 6 years ago

Summary of changes:

Added prop to close Dialog on outside click.

Behaviors that should be QA'd:

The Dialog box should close when a user clicks or touches outside the Dialog component

Github Issues closed by this PR:

Resolves #323

merlinbot commented 6 years ago

	Messages
:book:	### Modified Components * Dialog ### PR Application * [styled-material-components-pr-328](https://styled-material-components-pr-328.now.sh)

Generated by :no_entry_sign: dangerJS

brianpursell commented 6 years ago

That's my understanding. According to MDN, touchstart is widely supported by mobile browsers, while mousedown is not. @AriLFrankel mentioned that the Menu component already had the desired click behavior, so I mimicked the functionality of that component.

AriLFrankel commented 6 years ago

@brianpursell Thanks for this. Would you mind just squashing these commits together? Otherwise it LGTM Nice work 👍

brianpursell commented 6 years ago

No problem. They have been squashed.