Sensor Tag improvements suggestions

wassfila commented 3 years ago

I will target to add this sensor tag to the Zephyr project demo boards, for that to be accepted we have target a respectable quality for sw and hw. For the PCB, after writing the .dts and looking at other boards, there are minor improvements that help follow other nordic boards conventions to make users feel familiar Buttons

[x] I suggest to rename the buttons similar to the USB dongle, the REET simply called "RESET" and not S1
[x] the S2 then SW1 not S2
if possible to make the words "RESET" and "SW1" visible from the top view, currently hidden under the switch
- [x] The DEBUG / UART are way more helpful if they shift to top view, as I have to flip it every time to check
to have shorter names CLK / DIO would be enough and "DEBUG" can be replaced with SWD
- [x] I'm not sure if you really want to keep controlling the sensors with pios, does not seem to be necessary given the sleep modes of the sensors, it also makes it complex to align it with i2c drivers that are added in the dts, so not worth it. So unless you think controlling sensors with pio is really important, I would just simplify it.
the space where the sensors solder pads were if remove would leave space for name and version on top, would also be more practical

Informaticore commented 3 years ago

if possible to make the words "RESET" and "SW1" visible from the top view, currently hidden under the switch

Do you wear glasses? Next to the buttons on the top-silk you can read: "RESET" for the reset button and "EVENT" for the SW1 Button. The name EVENT was kind of mire appealing to me then naming it SW1. :) Or don't you have that on the Boards?

Informaticore commented 3 years ago

I'm not sure if you really want to keep controlling the sensors with pios, does not seem to be necessary given the sleep modes of the sensors, it also makes it complex to align it with i2c drivers that are added in the dts, so not worth it. So unless you think controlling sensors with pio is really important, I would just simplify it.

👍

wassfila commented 3 years ago

I do have "RESET" and "EVENT", the dts usually starts counting from SW0, SW1,... while the dongle they started counting from 1, 2, I can't see any sw0. The way the Thread sensor Tag now is opposed to the dongle and count from 1, maybe we can fix both issue in one by counting from 0

RESET = SW0 on schematics and on PCB only RESET visible
Event = SW1 on schematics and also SW1 can replace EVENT, the name is important as it should be matching the dts and is kind of a convention

wassfila commented 3 years ago

Or as second option count from 1 and name them identical to the dongle also fine for me SW1 SW2 and visible RESET / SW1

Informaticore commented 3 years ago

now I get it - you are talking about the designators! ok ok - yes, we can call them whatever we want, no opinions here. Usualy I would not even show them anyway

Informaticore commented 3 years ago

Changes can be found https://github.com/HomeSmartMesh/nrf52_thread_sensortag/commit/817515b1eede50786a12f2edd8fc7260cec3bc14

HomeSmartMesh / nrf52_thread_sensortag

Sensor Tag improvements suggestions #4