search

HomeX-It / open-mail-app-flutter

This library provides the ability to query the device for installed email apps and open those apps.
MIT License
36 stars 91 forks source link

Platform native pickers #36

Closed vbuberen closed 2 years ago

vbuberen commented 2 years ago

This PR replaces MailAppPickerDialog with a function, which takes care for user to create proper ActionSheet on iOS design making the picker look more or less native to the platform. Decided to not hide dialogs classes from users in case there is need to use one of them, but not sure if it was a good move.

Except for that also bumped some Android related dependencies and updated README with non-deprecated buttons in code example.

Did a minor version change due to introduced change, but feel that, ideally, such changed should be a major version change, since it is not backwards compatible. However, I don't know plans on reaching 1.0.0 for this plugin, so went with just minor bump.

Here is how iOS picker looks with introduced changes.

vbuberen commented 2 years ago

@MisterJimson Sorry for disturbing, but pinging in case you missed the notification about this PR.

MisterJimson commented 2 years ago

Hello! Thanks for taking the time to make this PR and sorry for the delay in reviewing.

The goal of this project is to abstract the accessing of information about the installed mail apps. With that data, apps are free to implement any UI they want. The current dialog in the project is just so people can test quickly when getting started.

I'm going to close this PR, because we don't want this project to have to maintain user interface components, but I appreciate the work!

Related to #26

vbuberen commented 2 years ago

Ok, thanks for your reply.

However, with changes in this PR it is still not an obstacle for somebody to create their own UI if needed while for users who don't really need anything special having a platform default option might be a good addition to functionality. It is just a matter of improving documentation and having both (custom UI and out-of-the-box UI) in example app.