search

HomeX-It / snowplow-flutter-tracker

Snowplow event tracker for Flutter. Add analytics to your Flutter apps and games http://snowplowanalytics.com
MIT License
5 stars 7 forks source link

Marks expiry as non-optional in ConsentGranted event #35

Closed ohitsdaniel closed 3 years ago

ohitsdaniel commented 3 years ago
Screenshot 2021-05-03 at 10 21 38

According to the Android Snowplow SDK, expiry is a @non-null field in ConsentGranted events. Therefore, we should also mark as non-optional in the Dart interface.

codecov[bot] commented 3 years ago

Codecov Report

Merging #35 (cf9d71f) into main (8154753) will decrease coverage by 0.03%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   21.13%   21.09%   -0.04%     
==========================================
  Files          28       28              
  Lines         672      673       +1     
==========================================
  Hits          142      142              
- Misses        530      531       +1
Impacted Files Coverage Δ
lib/src/events/consent_granted.dart 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8154753...cf9d71f. Read the comment docs.

MisterJimson commented 3 years ago

Thanks!