search

Homebrew / actions

🚀 Homebrew's GitHub Actions
BSD 2-Clause "Simplified" License
123 stars 39 forks source link

Replace deprecated set-output with GITHUB_OUTPUT #315

Closed bayandin closed 1 year ago

bayandin commented 2 years ago

Ref https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Bo98 commented 1 year ago

GITHUB_OUTPUT is now whitelisted so this should be ok.

I do not think the usage of Ruby should block this PR at all, given there's no new usages of Ruby here - only pre-existing, and the debate on the pros and cons are best settled in a separate discussion.

Bo98 commented 1 year ago

Will open a separate PR to handle permissions for file commands.

The permission stuff is honestly a bit of a mess. Short of GitHub/Docker properly supporting uid remapping, I had hoped to we could maybe handle this in our Dockerfile by defining an entrypoint that would just change the linuxbrew uid to match what GitHub expects, but it turns out entrypoints are disabled in GitHub Actions unless you have self-hosted with container hooks enabled (why??).

So I guess the cat and mouse game continues...

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.