search

Homebrew / actions

🚀 Homebrew's GitHub Actions
BSD 2-Clause "Simplified" License
122 stars 39 forks source link

Set `HOMEBREW_TEST_BOT_AUTOBUMP` in bump-packages #506

Closed apainintheneck closed 8 months ago

apainintheneck commented 8 months ago

This will unblock https://github.com/Homebrew/brew/pull/16750 by providing us with an environment variable that's only on when we're autobumping packages. In all other scenarios, we want people to get an error message if they try to bump one of the packages that gets regularly autobumped on CI.

Bo98 commented 8 months ago

Looks good but this can only be merged after the current incorrect usage of it in brew (dupe PR checking) is removed.

apainintheneck commented 8 months ago

Looks good but this can only be merged after the current incorrect usage of it in brew (dupe PR checking) is removed.

I just realized that.

I guess we need three PRs to be merged in this order, right?

  1. https://github.com/Homebrew/brew/pull/16781
  2. This one.
  3. https://github.com/Homebrew/brew/pull/16750
Bo98 commented 8 months ago

Yes

ZhongRuoyu commented 8 months ago

Do we want to set this in the autobump action in core and cask instead, or only when [[ "${GITHUB_REPOSITORY_OWNER}" == 'Homebrew' ]] is true? There is some usage of this action outside of Homebrew, where it doesn't seem necessary/reasonable to set HOMEBREW_TEST_BOT_AUTOBUMP.

https://github.com/search?q=Homebrew%2Factions%2Fbump-packages&type=code https://github.com/search?q=Homebrew%2Factions%2Fbump-formulae&type=code

apainintheneck commented 8 months ago

I think those are mostly forks but it's probably best to scope this down as much as possible anyway. I'll close this PR and then we can just add it to each repo.