search

Homebrew / actions

🚀 Homebrew's GitHub Actions
BSD 2-Clause "Simplified" License
122 stars 39 forks source link

{pre,post}-build: use actions/{upload,download}-artifact@v4 #529

Closed ZhongRuoyu closed 6 months ago

ZhongRuoyu commented 6 months ago

Companion to Homebrew/brew#17097.

Tested in ZhongRuoyu/homebrew-test#44.

Fixes #475.

Bo98 commented 6 months ago

Given the failed bottle name change: is there a concern for pr-pull glob matching existing runs? Might want to prioritise bottles over bottles-* if it exists.

ZhongRuoyu commented 6 months ago

Given the failed bottle name change: is there a concern for pr-pull glob matching existing runs? Might want to prioritise bottles over bottles-* if it exists.

Yes, was just thinking about this too. This is a real concern and we should avoid failed bottles generated from existing runs get accidentally picked up. Prioritising bottles seems to be a nice solution so that we won't have problems during migration.

ZhongRuoyu commented 6 months ago

Actually, this also brings problems to the bottle cache workflow. We could probably just choose a different pattern. I'll go with bottles_* instead. Then we could still do bottles{,_*}.

ZhongRuoyu commented 6 months ago

Now seems to be a good time to merge this. Long-timeout jobs have both started dep testing.

carlocab commented 6 months ago

🚢