Homebrew / brew-pip-audit

:clipboard: Bulk auditing Python dependencies in Homebrew with pip-audit
BSD 2-Clause "Simplified" License
11 stars 7 forks source link

Failing to generate any PRs #73

Closed alex closed 3 months ago

alex commented 6 months ago

https://github.com/Homebrew/brew-pip-audit/actions/runs/7985826380

@woodruffw at one point we talked about adding more debug info when this happens

woodruffw commented 6 months ago

Hmmm -- I thought I added some additional context from the SystemExit, but it looks like it doesn't percolate up. I'll look into it when I get a free moment.

alex commented 6 months ago

So the problem here seem to be that stderr is just shunted into the ether.

On Wed, Feb 21, 2024 at 12:21 PM William Woodruff @.***> wrote:

Hmmm -- I thought I added some additional context from the SystemExit, but it looks like it doesn't percolate up. I'll look into it when I get a free moment.

— Reply to this email directly, view it on GitHub https://github.com/Homebrew/brew-pip-audit/issues/73#issuecomment-1957376961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBF7BSNNPFXUYBFSEWLYUYUITAVCNFSM6AAAAABDS5E4AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGM3TMOJWGE . You are receiving this because you authored the thread.Message ID: @.***>

-- All that is necessary for evil to succeed is for good people to do nothing.

woodruffw commented 6 months ago

So the problem here seem to be that stderr is just shunted into the ether.

Yep -- I thought it got captured with SystemExit, but I was wrong. I think this will either need an upstream brew change to raise a real exception rather than just hard exiting, or some nastiness to capture stderr.

alex commented 6 months ago

FWIW, I think it'd be fine if the stderr from pip just got printed to the parent process's stderr, but I think right now it goes nowhere.

On Thu, Feb 22, 2024 at 4:10 PM William Woodruff @.***> wrote:

So the problem here seem to be that stderr is just shunted into the ether.

Yep -- I thought it got captured with SystemExit, but I was wrong. I think this will either need an upstream brew change to raise a real exception rather than just hard exiting, or some nastiness to capture stderr.

— Reply to this email directly, view it on GitHub https://github.com/Homebrew/brew-pip-audit/issues/73#issuecomment-1960320059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBBNGR3IHFGRKRFPK53YU6X6DAVCNFSM6AAAAABDS5E4AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGMZDAMBVHE . You are receiving this because you authored the thread.Message ID: @.***>

-- All that is necessary for evil to succeed is for good people to do nothing.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.