Homebrew / brew

🍺 The missing package manager for macOS (or Linux)
https://brew.sh
BSD 2-Clause "Simplified" License
41.43k stars 9.74k forks source link

add `Homebrew.install_bundler_gems!` to `brew update` #11419

Closed hyuraku closed 3 years ago

hyuraku commented 3 years ago

Provide a detailed description of the proposed feature

Homebrew.install_bundler_gems! works in brew update.

What is the motivation for the feature?

When I executed brew livecheck elmedia-player after brew style, an error happened Error: cannot load such file -- nokogiri like below error log, because brew update updated nokogiri version in Library/Homebrew/Gemfile.lock by https://github.com/Homebrew/brew/pull/11415 not install newer nokogiri gem.

How will the feature be relevant to at least 90% of Homebrew users?

avoid the error

What alternatives to the feature have been considered?

Manually brew install-bundler-gems after brew update

nandahkrishna commented 3 years ago

This is actually an issue with livecheck not running Homebrew.install_bundler_gems!, which is required only for the Sparkle strategy. You might want to take a look at https://github.com/Homebrew/discussions/discussions/1299, there is some useful discussion there, including a point about how this may still be problematic on ARM.