search

Homebrew / brew

🍺 The missing package manager for macOS (or Linux)
https://brew.sh
BSD 2-Clause "Simplified" License
41.43k stars 9.74k forks source link

Audit: Handle homepages with cloudflare and other security related curl errors #11706

Closed bevanjkay closed 3 years ago

bevanjkay commented 3 years ago

Provide a detailed description of the proposed feature

Add a flag to brew audit to disable the homepage check (would need to be manually verified). The flag would be able to be applied to cask CI checks with a label.

What is the motivation for the feature?

There is an increasing amount of casks that are failing CI due to curl being unable to fetch the homepage. In some cases, this can be mitigated by passing user_agent and other headers to the request, but does not help in others.

The flag would allow other tests to pass CI, and not require using syntax only checks, or overriding failures to merge PRs.

How will the feature be relevant to at least 90% of Homebrew users?

Would allow more Cask audits to pass without manual overrides.

What alternatives to the feature have been considered?

Another option could be to allow setting user_agent and other headers on homepage URLs (livecheck URLs as well) however this may not work in all circumstances.

bevanjkay commented 3 years ago

I am working on a draft PR that would add a --[no-]-homepage flag to the brew audit command.

MikeMcQuaid commented 3 years ago

I'd like to see this solved by https://github.com/Homebrew/brew/issues/11705 instead. I don't think we want to make manual verification a part of our workflow.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.