Improve `brew doctor` quarantine "unknown reason" message

wonbyte commented 1 week ago

`brew doctor` output

Warning: No Cask quarantine support available: unknown reason.

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

`brew config` output

brew config
HOMEBREW_VERSION: 4.4.0
ORIGIN: https://github.com/Homebrew/brew
HEAD: 84c31175f11860129a9aaed40a13c549625e2db1
Last commit: 8 days ago
Core tap JSON: 09 Oct 15:00 UTC
Core cask tap JSON: 09 Oct 15:00 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 16
Homebrew Ruby: 3.3.5 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.5/bin/ruby
CPU: 16-core 64-bit arm_palma
Clang: 15.0.0 build 1500
Git: 2.47.0 => /opt/homebrew/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 14.7-arm64
CLT: 15.3.0.0.1.1708646388
Xcode: N/A
Rosetta 2: false

What were you trying to do (and why)?

run brew doctor

What happened (include all command output)?

The command brew doctor says:

Warning: No Cask quarantine support available: unknown reason.

What did you expect to happen?

Not to receive a warning.

Step-by-step reproduction instructions (by running `brew` commands)

1. run `brew doctor`
2. Expect: Warning: No Cask quarantine support available: unknown reason.

wonbyte commented 1 week ago

See discussion for the issue here: https://github.com/orgs/Homebrew/discussions/5482

MikeMcQuaid commented 1 week ago

Reopening as we should try to improve the messaging here to be better based on https://github.com/orgs/Homebrew/discussions/5482

Bo98 commented 1 week ago

The uptick in reports appears to be an uptick of bad CLT installs ("15.3" installs that have a partially-installed 16.0). May need to report it to Apple if it's reproducible.

Clean install from developer.apple.com is a workaround for now. Maybe we can have a workaround from our side too to force an older SDK in this scenario.

wonbyte commented 1 week ago

Definitely think it's due to the "bad CLT installs". I had reinstalled macOS 14.7 and then installed CLT (Xcode-select --install). I just go an update for CLT (version 16) and after completing the upgrade I now see:

$ brew doctor

Your system is ready to brew.

So it appears after doing the initial CLT install, It was causing the warning. The upgrade to 16 resolved it.

Homebrew / brew