Closed domrim closed 4 years ago
Unfortunately it's expected behaviour that version.major_minor_patch
may return different values depending on changes to this repository. I'm not a cask maintainer but I'd advise hardcoding versions in URLs instead.
brew update
and can still reproduce the problem?brew doctor
, fixed all issues and can still reproduce the problem?brew config
andbrew doctor
and included their output with your issue?What you were trying to do (and why)
I tried to update the keepassxc cask to it's newest version (2.5.3-2). So i changed the
version
and thesha265
to the new values. Because the github download-link doesn't include the part after the dash i also fixed the download link fromto
according to the documentation in https://github.com/Homebrew/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/version.md
What happened (include command output)
When i now run
brew cask install keepassxc
following error appears:Command output
What you expected to happen
I expected
version.major_minor_patch
to return only2.5.3
instead of2.5.3-2
. I think the reason for this behaviour is the changes which were made in #6820 . This could also happen to other repos like these (found them withgrep -r . -e major_minor_patch | grep github
in homebrew-cask):I don't know what the best solution to this issue is? Here are my thoughts whats possible:
major_minor_path
REGEX to not accept dashes in version numbers. IMHO the easiest fix, also we wouldn need to change every cask which uses this filter.