Closed Eitot closed 8 years ago
Have a look at #1004 and let me know what you think.
$ brew info mpv
mpv: stable 0.20.0 (bottled), HEAD
...
==> Requirements
Required: python3 ✔, minimummacos = 10.8 ✔
Optional: x11 ✔
minimummacos
isn't very recognizable, might need a better display_s
.
How about MinMacOS = 10.8
? Or are you concerned about the numeric vs. names like :yosemite
/:el_cap
/etc?
Probably, MinimumMacOS
and MaximumMacOS
are better, because they align with the DSL and are readable.
I think minimum/min macOS version
and maximum/max macOS version
would be clearer and look nicer, but no objection to MinimumMacOS
.
Or are you concerned about the numeric vs. names like :yosemite/:el_cap/etc?
Not at all. One day some people will forget what Lion is, just like I don't know what Panther is right now.
Cool. I think the numbers work better too.
I lean toward the run-together MinimumMacOS
/MaximumMacOS
because they're closer to the DSL. Pushed an amended commit to the PR.
Shall we move this conversation over to the PR itself? https://github.com/Homebrew/brew/pull/1004
Sure.
brew update
and retried your prior step?brew doctor
, fixed as many issues as possible and retried your prior step?Bug report
brew info mpv
does not mention the Python3 dependency. Is this intentional?brew deps mpv
works correctly.