Closed jonathandhn closed 6 months ago
Probably because site generation runs on macOS 12 still (macos-latest
still points to macos-12
, but we could manually point to macos-13
).
robably because site generation runs on macOS 12 still (
macos-latest
still points tomacos-12
, but we could manually point tomacos-13
).
Yup. Addressed the title because I think the actual good fix for this is to use the brew info --json --cask
output (adding the new data if needed) to display a table of possible versions in cases like this because this pattern is so commonplace.
So do we want to show the latest macOS version? Or all of the supported ones?
@SMillerDev All supported.
For anyone interested in tackling this: right now all of this info exists in the variations
part of the JSON. We used to have a versions
item in the JSON that contained exactly this info (added in https://github.com/Homebrew/formulae.brew.sh/pull/539 and https://github.com/Homebrew/brew/pull/11915, and removed in https://github.com/Homebrew/formulae.brew.sh/commit/b5704d4e26835d07c8aa5bbcb7ed25ac2a08a405 and https://github.com/Homebrew/brew/pull/15240).
It might be worth looking into re-adding versions
to the APIs, only to be added when running --variations
to not slow down generation too much except for when we're generating for the website
Edit: oops, now I see there's already a PR open for this
It might be worth looking into re-adding
versions
to the APIs, only to be added when running--variations
to not slow down generation too much except for when we're generating for the website
@Rylan12 I think we need to have Homebrew/brew do the same as what we're doing for the website. I'm open to @Bo98 and @apainintheneck thoughts on how best to balance this as I agree including this information would be nice.
Which APIs are we planning on adding cask variations to? I checked brew info --json=v2 --variations
and the JSON representation of casks on formulae.brew.sh
and both already included variations.
I'm not convinced anything more needs done here?
Only remaining improvement to the webpages is I'd make is to fold "Current version" into the variations table as that version actually means "Version of the machine that generated this page (Monterey)". Example (note how Monterey is missing): https://formulae.brew.sh/cask/mysqlworkbench
Could we get that info though?
"Current version" applies to all missing variations, so the extra information we would need is the set of possible macOS versions. We could extract that from brew
at build time perhaps - we have full control of the build now and can execute arbitrary Ruby code during the Jekyll build unlike the other brew.sh repos.
It would fill up the table on e.g. https://formulae.brew.sh/cask/amethyst a bit but it would behave consistently so would probably look ok (though that cask doesn't make sense anyway because of the >= 10.15, but that's an issue for homebrew-cask).
In addition, we probably should also make it so API generation more system-agnostic. i.e. it simulates the latest x86_64 macOS so "current version" refers to macOS 14 even if generated on macOS 12. GitHub-hosted runners lagging over a year behind is probably not going to change anytime soon.
In addition, we probably should also make it so API generation more system-agnostic. i.e. it simulates the latest x86_64 macOS so "current version" refers to macOS 14 even if generated on macOS 12.
Agreed šš»
I think a happy middle ground could be a new field added to the API clarifying what the machine it was generated on is.
Looking at https://formulae.brew.sh/cask/mysqlworkbench#default, this can be closed right?
Yes, thanks @SMillerDev!
There is a cask version mismatch between cask formula and formulae.brew.sh on the MySQL Workbench cask
formulae.brew.sh show as of UTC 9:40 pm 20th of september 2023 :
When copied and pasted
Current version: [8.0.32](https://cdn.mysql.com/Downloads/MySQLGUITools/mysql-workbench-community-8.0.32-macos-x86_64.dmg)
While cask code on the same time shows :
and