search

Homebrew / homebrew-bundle

📦 Bundler for non-Ruby dependencies from Homebrew, Homebrew Cask and the Mac App Store.
MIT License
5.33k stars 285 forks source link

bundle dump: fix whalebrew dump output #1422

Closed nathanielvarona closed 2 months ago

nathanielvarona commented 2 months ago

I have a few whalebrew packages installed

$ whalebrew list

COMMAND          IMAGE
figlet           whalebrew/figlet
graph-easy       nathanielvarona/graph-easy
octodns-compare  whalebrew/octodns-compare
whalesay         whalebrew/whalesay

However, if I use the Bundle Dump from Homebrew, the results look like:

whalebrew "whalebrew/figlet"
whalebrew "graph-nathanielvarona/graph-easy"
whalebrew "octodns-whalebrew/octodns-compare"
whalebrew "whalebrew/whalesay"

The expected output supposedly:

whalebrew "whalebrew/figlet"
whalebrew "nathanielvarona/graph-easy"
whalebrew "whalebrew/octodns-compare"
whalebrew "whalebrew/whalesay"

I created the PR to fix this issue of dumping the packages list from Whalebrew.

With the fixes, running the brew bundle dump --no-lock --describe --force --file ./whalebrew.Brewfile --whalebrew again and I get the expected output.

Here is the whalebrew dump output difference now:

diff --git a/whalebrew.Brewfile.with-error b/whalebrew.Brewfile
index e5a1878..bd0c6c3 100644
--- a/whalebrew.Brewfile.with-error
+++ b/whalebrew.Brewfile
@@ -1,4 +1,4 @@
 whalebrew "whalebrew/figlet"
-whalebrew "graph-nathanielvarona/graph-easy"
-whalebrew "octodns-whalebrew/octodns-compare"
+whalebrew "nathanielvarona/graph-easy"
+whalebrew "whalebrew/octodns-compare"
 whalebrew "whalebrew/whalesay"
MikeMcQuaid commented 2 months ago

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @nathanielvarona!