vitorgalvao
commented
5 years ago Does it work for any other cask? Because it looks more like you have a broken style command.
Closed robertleeblairjr closed 5 years ago
vitorgalvao
commented
5 years ago Does it work for any other cask? Because it looks more like you have a broken style command.
robertleeblairjr
commented
5 years ago Does it work for any other cask? Because it looks more like you have a broken
stylecommand.
Here's the output of 'brew cask style' which should check all casks. I've even style checked individual cask files. This was the only one failing.
== /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-drivers/Casks/canon-pixma-scanner-driver-ica.rb ==
C: 10: 35: Prefer annotated tokens (like %<foo>s) over unannotated tokens (like %s).
4853 files inspected, 1 offense detected
Error: Style check failed.@robertleeblairjr Why didn’t you put that in the top post? That’s the only part that mattered. It should’ve been in the Description of issue.
Also, you wanted a fenced code block, not backticks. Already fixed the post.
vitorgalvao
commented
5 years ago @reitermarkus I’ve read about annotated tokens, and I’m failing to see their usefulness or how they could be used in this situation. The examples in Rubocop’s documentation are particularly poor.
Is this a style check we should remove, or how do we comply?
robertleeblairjr
commented
5 years ago @robertleeblairjr Why didn’t you put that in the top post? That’s the only part that mattered. It should’ve been in the
Description of issue.Also, you wanted a fenced code block, not backticks. Already fixed the post.
You do realize that people who contribute may not know certain aspects of submitting but also since they don't know are freely doing these things in their free time. You're snippy responses over a period have time have only shown me that you either don't know how to communicate with people or don't really care to improve on them. Fix it yourself since you want to be a d'bag about it.
vitorgalvao
commented
5 years ago @robertleeblairjr I apologise if my interactions to you sounded rude, as that was not my intention. I do, however, have to optimise for time because I too am doing this in my free time, and in a considerably larger scale — I interact with literally dozens of PRs and issues on a daily basis on this project alone. Being terse is a necessity.
I disagree I “don't know how to communicate with people” because the vast majority of users I interact with on this project don’t have an issue with the way I communicate with them. Over the years more have thanked me for my interactions than rebuked me. Still, I won’t pretend to be a paragon of virtue. I know that sometimes I fail, but I try to always recognise and fix it.
You may have read the fenced code block bit as ill-mannered, but others would have appreciated it for the new information, the link that explains it in depth, and for having it already fixed by the time they read the post, saving them the trouble. I know because that’s a variation on a standard reply that is usually appreciated.
I genuinely have no idea what you mean by “fix it yourself”, since nobody asked you to fix anything. I fixed your own post for you and asked another maintainer for a suggestion on how to proceed with the error you reported (and that we appreciate you doing so); there’s nothing else for you to do.
Read my posts as I wrote them — genuine questions and assertions — instead of accusations and criticisms, and you may see them as they were intended. My time with HBC has thought me to always read user posts as if they were written with a smile, because most times you read rudeness into something, it wasn’t there.
I do concede my compass may be a bit off these days because I’m currently sick, but I’m confident I haven’t resorted to name-calling, and would appreciate the same courtesy.
Still, I will reinforce my apology at having upset you. We can all have our bad days and deserve a pass. I don’t think it’s fair to make @reitermarkus have to reply after this exchange, so I’ll close and make a new issue for the question. Thank you again for the report.
vitorgalvao
commented
5 years ago robertleeblairjr
commented
5 years ago @robertleeblairjr I apologise if my interactions to you sounded rude, as that was not my intention. I do, however, have to optimise for time because I too am doing this in my free time, and in a considerably larger scale — I interact with literally dozens of PRs and issues on a daily basis on this project alone. Being terse is a necessity.
I disagree I “don't know how to communicate with people” because the vast majority of users I interact with on this project don’t have an issue with the way I communicate with them. Over the years more have thanked me for my interactions than rebuked me. Still, I won’t pretend to be a paragon of virtue. I know that sometimes I fail, but I try to always recognise and fix it.
You may have read the fenced code block bit as ill-mannered, but others would have appreciated it for the new information, the link that explains it in depth, and for having it already fixed by the time they read the post, saving them the trouble. I know because that’s a variation on a standard reply that is usually appreciated.
I genuinely have no idea what you mean by “fix it yourself”, since nobody asked you to fix anything. I fixed your own post for you and asked another maintainer for a suggestion on how to proceed with the error you reported (and that we appreciate you doing so); there’s nothing else for you to do.
Read my posts as I wrote them — genuine questions and assertions — instead of accusations and criticisms, and you may see them as they were intended. My time with HBC has thought me to always read user posts as if they were written with a smile, because most times you read rudeness into something, it wasn’t there.
I do concede my compass may be a bit off these days because I’m currently sick, but I’m confident I haven’t resorted to name-calling, and would appreciate the same courtesy.
Still, I will reinforce my apology at having upset you. We can all have our bad days and deserve a pass. I don’t think it’s fair to make @reitermarkus have to reply after this exchange, so I’ll close and make a new issue for the question. Thank you again for the report.
I'm cool. However, my reply wasn't based upon this one response you've had with anything that I've posted. It's been quite a few times and I chose to not interpret past ones in a demeaning manner. But, I'm not mistaken when it comes to how you choose to reply to certain people. So, this one was just the straw that broke the camel's back in biting my tongue for ignoring them. I highly value criticism since I'm constantly learning but I definitely don't attempt to reply to someone with the intent that they're just making your job more difficult. A good portion of the people who do basic PR's are just as clueless as I am about the Ruby language or even better methods to submit PRs. However, I realize there's value in everyone no matter if it's nothing more than an update to versions for programs and they can do nothing more whether because of lack in knowledge or just mere time. Either way, it's forgotten now and moving on.
General troubleshooting steps
--force.brew update-reset && brew updateand retried my command.brew doctor, fixed as many issues as possible and retried my command.Description of issue
Cask canon-pixma-scanner-driver-ica fails style check.
Command that failed
Output of command with
--force --verbose --debugOutput of
brew cask doctorOutput of
brew tap