Homebrew / homebrew-cask-fonts

💀 Casks of F🅾𝓝𝐓𝚂 (deprecated)
https://brew.sh
2.86k stars 463 forks source link

Bump Monaspace font version to v1.100 #9320

Closed arjpar closed 5 months ago

arjpar commented 5 months ago

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:


Let me know if there are any problems. Unless they removed/added/renamed any specific files in the fonts/otf/ directory, meaning specific styles and weights, everything should work fine.

arjpar commented 5 months ago

@miccal There seems to be an error on my end.

Error: homebrew/cask-fonts/font-monaspace: SHA256 mismatch
Expected: 6cdd653e3f6708585f563c86b1e19a63a02dc95b46d1c8924dc19e55d834967e
  Actual: c8f7e1a497cc128181d399b259b51e6fe332f7d0fed1fbb49bb05076a7753a9f

Despite sha256sum for monaspace-v1.100.zip returning 6cdd653e3f6708585f563c86b1e19a63a02dc95b46d1c8924dc19e55d834967e

After further investigating, seems like the zip I downloaded had a different sha256 than the zip I downloaded just now. They were both the latest (v1.100) versions of the font, and both from the GitHub releases. It seems like one of them had .git and .gitignore and the (now) correct one doesn't have those files. Weird. I'll submit another PR fixing the sha256 string if you want. The correct sha256 (now) is c8f7e1a497cc128181d399b259b51e6fe332f7d0fed1fbb49bb05076a7753a9f.

Edit: Turns out there already is an open PR with the correct sha256 string. I apologize for my error!

miccal commented 5 months ago

No problem @arjpar, these things happen.