Homebrew / homebrew-cask

🍻 A CLI workflow for the administration of macOS applications distributed as binaries
https://brew.sh
BSD 2-Clause "Simplified" License
20.95k stars 10.73k forks source link

livecheck for coteditor and eaglefiler #100024

Closed tiiiecherle closed 3 years ago

tiiiecherle commented 3 years ago

Description of feature/enhancement

Two casks that we are using, coteditor and eaglefiler, do not have the livecheck yet. It would be nice if it could be added. Thanks

I'm sorry I am not familiar with the syntax. Is there a wiki/manual about the options and syntax of livecheck for the next time? Thanks

adithyasunil26 commented 3 years ago

The documentation for the livecheck stanza can be found here

tiiiecherle commented 3 years ago

@adithyasunil26 Thanks. But how do I know which strategy to apply?

For coteditor guessing was not so hard and

  livecheck do
    url :url
    strategy :github_latest
  end

seems to work.

After trial an error this seems to work for eaglefiler:

  livecheck do
    url :homepage
    strategy :page_match
    regex(%r{href=.*?/EagleFiler-(\d+(?:\.\d+)*)\.dmg}i)
  end

Does that seem right? My first try was using the download url "https://c-command.com/downloads/" but I couldn't get it to work.

tiiiecherle commented 3 years ago

Trying a first pull request for coteditor here.

tiiiecherle commented 3 years ago

Coteditor failed due to a style issue I don't know how to solve.

Trying eaglefiler here.

vitorgalvao commented 3 years ago

Both of these are on their way to being merged. Thank you for doing them.