search

Homebrew / homebrew-cask

🍻 A CLI workflow for the administration of macOS applications distributed as binaries
https://brew.sh
BSD 2-Clause "Simplified" License
20.95k stars 10.73k forks source link

Wolfram Engine cask can't be bumped #106909

Closed pthariensflame closed 3 years ago

pthariensflame commented 3 years ago

Version 12.3.0.0 of wolfram-engine is available, but upon trying to use bump-cask-pr it fails to download. Manually altering the cask produces similar results.

It seems as if the new URL is of the form https://files.wolframcdn.com/packages/Homebrew/12.3.0.0/WolframEngine_12.3.0_MAC.dmg?hashMAC_.dmg, where hash is some hash that changes every download. https://account.wolfram.com/download/public/wolfram-engine/desktop/MAC gets the correct download by redirection but doesn't encode the version number anymore.

What should be done?

carlocab commented 3 years ago

Using the second (unversioned) download while getting rid of the checksum verification might be the right thing to do here. That's seems to be what we do elsewhere, but I'm more than happy for another maintainer to point out a better way here.

cho-m commented 3 years ago

The Cask was originally added in #98512 with direct download URL for Homebrew to avoid the GUI download manager.

Given that the new URL appears to be ~1.1GB, I'm guessing that Wolfram has changed how the app is distributed?

Maybe @ConnorGray can comment on this.

There is also the URL format from wolfram-player, but it doesn't work for older 12.2.0 (though it works for 12.3.0). So, hard to tell if this URL format will be supported in future or not.

EDIT: Just tried opening DMG and see that there is a 2-step installation. Not sure if this was how 12.2.0 looked. EDIT 2: Seems to be same as 12.2.0. Probably adds wolframscript as command.

ConnorGray commented 3 years ago

I've just uploaded our WE 12.3 dmg file to:

https://files.wolframcdn.com/packages/Homebrew/12.3.0.0/WolframEngine_12.3.0_MAC.dmg

so @pthariensflame I believe it should be possible for you to proceed with running bumb-cask-pr.

I apologize for the delay in uploading this file. We're working to update our release process to ensure that these file stay in-sync.

Please let me know if this fixes the issue, and if there is any further action we can take.

miccal commented 3 years ago

@ConnorGray is there any chance you can add something like https://files.wolframcdn.com/packages/Homebrew/latest.txt which lists the version 12.3.0.0 so we can add a livecheck?

cho-m commented 3 years ago

Created #107383 to close this.

For now, we can livecheck headers on unversioned download URL; however, if Homebrew-specific download link is not updated at same time, then it can lead to similar issue as this where bump cask fails.