Homebrew / homebrew-cask

🍻 A CLI workflow for the administration of macOS applications distributed as binaries
https://brew.sh
BSD 2-Clause "Simplified" License
20.95k stars 10.73k forks source link

Battle for Wesnoth cask is currently using develop version #120832

Closed gggto closed 2 years ago

gggto commented 2 years ago

Verification

Description of issue

Battle for Wesnoth uses an even is stable, odd is dev versionning scheme. Currently, the last stable version is 1.16.2, while on homebrew it is 1.17.0, which I as just explained is the dev version.

To avoid this kind of errors in the future, the livecheck in https://github.com/Homebrew/homebrew-cask/blob/master/Casks/the-battle-for-wesnoth.rb could become something along the lines of regex(href=.*?Wesnoth[._-]v?(\d+(?:\.\d*[02468])+(?:\.\d+)*[a-z]?)\.dmg/i, which should have the expected behaviour.

Command that failed

none

Output of command with --verbose --debug

none

Output of brew doctor --verbose

none

Output of brew tap

none
bevanjkay commented 2 years ago

@gggto Please open a PR with your suggested change and we can discuss the implementation there.