Homebrew / homebrew-cask

🍻 A CLI workflow for the administration of macOS applications distributed as binaries
https://brew.sh
BSD 2-Clause "Simplified" License
20.69k stars 10.59k forks source link

Casks with Sparkle/Electron and no auto_update #170994

Open krehel opened 3 months ago

krehel commented 3 months ago

Applications that use Sparkle or Electron typically have their updates managed automatically through a feed and can update outside of Homebrew. At some point, the Casks below were added to Homebrew but are not marked as having automatic updates.

Accordingly, below is the list of Casks that are using either :sparkle or :electron_builder as a livecheck strategy, but do not have auto_updates true.

The ask for each app would be as follows -

  1. Verify the livecheck information is correct and does return the latest version, verified by another means than the livecheck.
  2. If the information is not correct, please update the livecheck to appropriately return the version information. That can be through :sparkle or :electron_builder, or another means if those are not returning the proper information.
  3. Verify if the application should have auto_update true, and if so then please add it and open a PR. If a screenshot can be captured showing the automatic update feature and added to the PR, that would be a great addition.
  4. Please update any other aspects of the Cask that may be outdated, especially if multiple versions behind current.
  5. Please link the PR beside the Cask name in this issue, or comment with the PR and a maintainer can update this list.
  6. If it should not have auto_update true and requires no additional changes, then please check it off this list or mention in comment.
  7. If the Cask is no longer offered, is moved to the Mac App Store, or is otherwise no longer developed, please open a PR to mark as deprecated for Homebrew Maintainers to consider.
  8. If you need help, please feel free to mention me here or in a PR.
SMillerDev commented 3 months ago

Should we have an audit for this? It seems easy to check this programmatically

bevanjkay commented 3 months ago

It seems like a reasonable idea. It depends if there are any scenarios where the auto update mechanism doesnt work despite there being a feed available.

SMillerDev commented 3 months ago

We can always make an allowlist

krehel commented 3 months ago

That's probably the way to go re: allowlist

I have seen -some- Casks (don't recall which) that use Electron but not the auto-update feature. I don't believe I've seen any that use Sparkle and don't auto-update.

swrobel commented 1 month ago

https://github.com/Homebrew/homebrew-cask/pull/176008