Homebrew / homebrew-cask

🍻 A CLI workflow for the administration of macOS applications distributed as binaries
https://brew.sh
BSD 2-Clause "Simplified" License
20.63k stars 10.58k forks source link

Add `calibrite-profiler` #174161

Closed MTCoster closed 2 weeks ago

MTCoster commented 2 weeks ago

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:


This app isn't open source - it just uses GitHub releases for asset hosting. The latest stable release as per the download page and release notes is the current "pre-release" as marked on GitHub. Add to github_prerelease_allowlist to ignore the lint.

The brew audit --cask --new check fails with two issues:

 - Upstream defined :high_sierra as the minimum OS version and the cask defined :catalina
 - GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)

The first is a conflict between Info.plist (which says High Sierra 10.13) and the vendor website (which says Catalina 10.15). The second is the same GitHub issue as the pre-release above, but with no obvious equivalent allowlist to exempt it.

This cask previously existed in cask-drivers as calibrite-ccprofiler - it was renamed at some point and never updated, then removed completely during the migration back to cask due to lack of use.

MTCoster commented 2 weeks ago

Thanks for the review @bevanjkay – I’ve made the suggested changes