Convert scripts in `developer/bin` to Homebrew commands

bevanjkay commented 3 months ago

This is a proposal for how deal with the scripts in developer/bin. Below is what I think we can keep / remove.

Migrate to a Homebrew Command

[ ] casks-without-zap
[x] find-appcast
[ ] generate_cask_token
[ ] list_recent_pkg_ids (potentially combine with list_pkg_ids_by_regexp command with arguments)
[ ] list_pkg_ids_by_regexp
[ ] list_loaded_launchjob_ids (potentially combine with list_installed_launchjob_ids command with arguments)
[ ] list_installed_launchjob_ids
[ ] list_running_app_ids
[ ] list_id_in_kext
[ ] list_ids_in_app
[ ] list_ids_in_pkg (potentially combine into list-in-pkg with arguments)
[ ] list_payload_in_pkg (potentially combine into list-in-pkg with arguments)
[ ] list_apps_in_pkg (potentially combine into list-in-pkg with arguments)
[ ] list_loaded_kext_ids
[ ] list_login_items_for_app

Potentially Remove

[ ] list_url_attributes_on_file
[ ] update_cask_family
[ ] update_multilangual_casks
[ ] cask-pr-local-check
[ ] cask-pr-inspect-download

Requires Python for Protobuf handling so may be complicated to convert to Ruby

[ ] import_google_fonts

Re-add `font_casker` script from `homebrew-cask-fonts`

[ ] https://github.com/Homebrew/homebrew-cask-fonts/blob/88357e6c0516bf53524696393f12d4d073139a5d/developer/bin/font_casker

bevanjkay commented 3 months ago

@Homebrew/cask Interested in some feedback here to see what is used often.

I am not sure how many of the helpers we need to keep for building casks, as it seems most "ids" and "loaded items" are discovered on CI anyway, which I personally don't have a problem with.

p-linnane commented 3 months ago

@Bo98 advised that we can probably use https://github.com/mrkn/pycall.rb for the fonts one.

Bo98 commented 3 months ago

Is the proposal to move them to $(brew --repo homebrew/cask)/cmd (like homebrew-core's rebottle command)? If so: makes sense.

Some of the more generic ones that would be useful for third-party cask taps could be in Homebrew/brew, with modifications. For example, integrating scripts like generate_cask_token into brew create (and/or an audit) probably makes sense.

bevanjkay commented 3 months ago

Is the proposal to move them to $(brew --repo homebrew/cask)/cmd (like homebrew-core's rebottle command)? If so: makes sense.

Yeah, this exactly.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Homebrew / homebrew-cask