search

Homebrew / homebrew-cask

🍻 A CLI workflow for the administration of macOS applications distributed as binaries
https://brew.sh
BSD 2-Clause "Simplified" License
20.88k stars 10.7k forks source link

minergate #45664

Closed brianbrownton closed 6 years ago

brianbrownton commented 6 years ago

The current version is 8.0, I am trying to submit a PR for8.1.

It seems the download URL for the current version differs from the past (and their archive).

Expected (and url for past versions): https://download.minergate.com/mac/#{version} (eg 8.0) Current: https://download.minergate.com/mac

Should this cask be updated to :latest and :no_check?

Contents for current cask, for reference:

cask 'minergate' do
  version '8.0'
  sha256 '2211c1be48c09225dcd27e6223a8243d40334932951fba6257e53220a55afbe7'

  url "https://download.minergate.com/mac/#{version}"
  name 'MinerGate'
  homepage 'https://minergate.com/downloads/gui'

  app 'MinerGate.app'

  zap trash: [
               '~/Library/Application Support/minergate',
               '/Library/Logs/DiagnosticReports/minergate_*',
             ]
end
reitermarkus commented 6 years ago

If only https://download.minergate.com/mac works, then it should be :latest.

brianbrownton commented 6 years ago

https://github.com/caskroom/homebrew-cask/pull/45666